[v3-1-test] Fix log task instance join (#59973)#60208
Closed
github-actions[bot] wants to merge 1 commit intov3-1-testfrom
Closed
[v3-1-test] Fix log task instance join (#59973)#60208github-actions[bot] wants to merge 1 commit intov3-1-testfrom
github-actions[bot] wants to merge 1 commit intov3-1-testfrom
Conversation
* Fix incorrect Log and TaskInstance join query * Fix log task instance join foreign keys and remove stray newsfragment * Remove unused task variable assignments in test_log_task_instance_join_correctness * Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting * Restore newsfragment and fix missing import in log.py * Fix reviewer feedback: add license, move imports, and fix newsfragments * Fix ruff static check failure in log.py * Flatten primaryjoin definition to fix formatting * Fix newsfragments per review: restore 58337 and remove 59965 * Remove unused import in log.py --------- (cherry picked from commit 91af86e) Co-authored-by: Subham <subhamsangwan26@gmail.com> Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Member
|
@Subham-KRLX - this backport introduces errors on v3-1-test - maybe you can fix those if we are to backport the fix? |
Comment on lines
+53
to
+60
| dag_model: Mapped[DagModel | None] = relationship( | ||
| "DagModel", | ||
| viewonly=True, | ||
| foreign_keys=[dag_id], | ||
| primaryjoin="Log.dag_id == DagModel.dag_id", | ||
| ) | ||
|
|
||
| task_instance = relationship( | ||
| task_instance: Mapped[TaskInstance | None] = relationship( |
Member
There was a problem hiding this comment.
Yes, must be these sqlalchemy2.0 annotation type that CI is not happy about.
Contributor
|
I have created a manual backport to fix the CI issues in I have opened a new PR with the fix (removing type hints while keeping the logic correction): #60222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect Log and TaskInstance join query
Fix log task instance join foreign keys and remove stray newsfragment
Remove unused task variable assignments in test_log_task_instance_join_correctness
Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting
Restore newsfragment and fix missing import in log.py
Fix reviewer feedback: add license, move imports, and fix newsfragments
Fix ruff static check failure in log.py
Flatten primaryjoin definition to fix formatting
Fix newsfragments per review: restore 58337 and remove 59965
Remove unused import in log.py
(cherry picked from commit 91af86e)
Co-authored-by: Subham subhamsangwan26@gmail.com
Co-authored-by: Jason(Zhe-You) Liu 68415893+jason810496@users.noreply.github.com